On 4/7/06, jerenkrantz@tigris.org <jerenkrantz@tigris.org> wrote:
> Author: jerenkrantz
> Date: Fri Apr 7 22:31:35 2006
> New Revision: 19251
>
> Added:
> trunk/subversion/libsvn_ra_serf/replay.c
> Modified:
> trunk/subversion/libsvn_ra_serf/commit.c
> trunk/subversion/libsvn_ra_serf/property.c
> trunk/subversion/libsvn_ra_serf/ra_serf.h
> trunk/subversion/libsvn_ra_serf/serf.c
>
> Log:
> ra_serf: Implement replay functionality; fix some session reuse bugs triggered
> by replay. (Passes all svnsync tests.)
Excellent! A few comments though...
> + else if (state == REPORT &&
> + strcmp(name.name, "open-root") == 0)
> + {
> + const char *rev;
> + replay_info_t *info;
> +
> + rev = svn_ra_serf__find_attr(attrs, "rev");
> +
> + info = push_state(parser, ctx, OPEN_DIR);
> +
> + SVN_ERR(ctx->editor->open_root(ctx->editor_baton,
> + SVN_STR_TO_REV(rev), parser->state->pool,
> + &info->baton));
It seems like there should be some error checking on the rev
attribute, what if it isn't there? Similar things could be said for
the rest of the editor calls in this file.
-garett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 8 07:42:14 2006