[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19194 - in branches/fs-atomic-renames/subversion: include libsvn_delta libsvn_repos

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-04-06 18:37:25 CEST

On Thu, 06 Apr 2006, Peter N. Lundblad wrote:

> rooneg@tigris.org writes:
...
> > Log:
> > On the fs-atomic-renames branch:
> >
> > Rev the delta editor interface to support renames.
...
> Should we take the oportunity to call this svn_delta_editor_create to use
> a similar name to many other constructor functions?

+1, svn_delta_default_editor() is an aberration.

Also, should svn_delta_editor_to_editor2() really be in the public
header file? Seems like an implementation detail to me.

...
> When you do the bulk of this: change everything to use the new editor,
> will you move that work to trunk, then? I really hope you will.
> (Except for the rename stuff, of course).

This might complicate subsequent porting of the backend renames
changes, but if Garrett is up for that added pain, it would be nice to
have these API changes sooner than later.

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Thu Apr 6 18:38:14 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.