[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r19183 - trunk/subversion/libsvn_wc

From: Madan U S <madan_at_collab.net>
Date: 2006-04-05 14:58:04 CEST

On Wednesday 05 Apr 2006 5:47 pm, lundblad@tigris.org wrote:
> Author: lundblad
> Date: Wed Apr 5 05:17:56 2006
> New Revision: 19183
>
> Modified:
> trunk/subversion/libsvn_wc/entries.c
> trunk/subversion/libsvn_wc/entries.h
[snip]
> Modified: trunk/subversion/libsvn_wc/entries.c
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_wc/entries.c?pathr
>ev=19183&r1=19182&r2=19183
> ===========================================================================
>=== --- trunk/subversion/libsvn_wc/entries.c (original)
> +++ trunk/subversion/libsvn_wc/entries.c Wed Apr 5 05:17:56 2006
> @@ -157,6 +157,9 @@
>
> /* Don't leave home without one. */
> apr_pool_t *pool;
> +
> + /* Cleared before handling each entry. */
> + apr_pool_t *scratch_pool;
> };
>
>
> @@ -220,7 +223,7 @@
> if (name && strcmp(name, "svn:this_dir") == 0)
> name = SVN_WC_ENTRY_THIS_DIR;
> }
> - entry->name = name ? name : SVN_WC_ENTRY_THIS_DIR;
> + entry->name = name ? apr_pstrdup(pool, name) : SVN_WC_ENTRY_THIS_DIR;
>
> /* Attempt to set revision (resolve_to_defaults may do it later, too) */
> {
> @@ -242,7 +245,10 @@
> = apr_hash_get(atts, SVN_WC__ENTRY_ATTR_URL, APR_HASH_KEY_STRING);
>
> if (entry->url)
> - *modify_flags |= SVN_WC__ENTRY_MODIFY_URL;
> + {
> + *modify_flags |= SVN_WC__ENTRY_MODIFY_URL;
> + entry->url = apr_pstrdup(pool, entry->url);

sorry, I dont understand why this is done... could you pl. explain this, lundblad? (There are other similar usages of apr_pstrdup() in the rest of the diff, but am taking this as an example)

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Wed Apr 5 14:59:08 2006

This is an archived mail posted to the Subversion Dev mailing list.