On Fri, 31 Mar 2006, Garrett Rooney wrote:
...
> So what does this mean to the rest of the system? Well, not a whole
> lot yet. If you use a direct call to svn_fs_move to rename a file
> inside your filesystem it will currently show up as a move in verbose
> log output (the V letter instead of D, A, R, or M).
This will have an impact on folks who wrap the command-line client (or
even the svn_client_log functions?).
...
> The current code makes svn_fs_copied_from treat renames just like
> copies. cmpilato has a philosophical objection to that, and we've
> also discussed the possibility of moving the copyfrom info directly
> into the log results, since the basic use case seems to be "run log
> functions, get something that might be a copy, run copied_from to
> check". It seems like we could just skip some steps by returning that
> info in the first place, and we can possibly make it more efficient
> due to the way some of that is being stored in the copies table, which
> we're already traversing.
...
+1 on returning the info in the first place, rather than jumping
through extra hoops to and fro the file system.
--
Daniel Rall
- application/pgp-signature attachment: stored
Received on Tue Apr 4 00:31:23 2006