r16476 broke binary compatibility with 1.0/1.1 clients

Hi Peter,

r16476 (adding diff --summarize API calls) effectively changed the
prototype for svn_ra_plugin_t->do_diff() vtable member (though you
changed only the callers and implementations, not the svn_ra_plugin_t
structure itself, so the prototype and uses are actually mismatched).

This will break direct users of the vtable, won't it? (i.e. all callers
written against the 1.0 or 1.1 API).

I guess that we need to split the RA vtables into a private-use vtable for
the flat svn_ra_xxx functions and a 'public' vtable for 1.0/1.1 callers;
the latter would then have a reference to a compatbility diff function
that doesn't expect the text_deltas argument.

Sorry I didn't notice this before - I just spotted it while researching
how to add my own extra parameter to svn_ra_diffX.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 30 16:51:48 2006