[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] show log message before changed paths in mailer.py

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-03-30 03:55:35 CEST

C. Michael Pilato wrote:
> Julian Foad wrote:
>
>>>>+ w('Author: %s\nDate: %s\nNew Revision: %s\n\nLog: %s\n\n'
>>>>+ % (data.author, data.date, data.rev, data.log))
>>[...]
>>>>- w('\nLog:\n%s\n' % data.log)
>>
>>... it looks to me like it wrongly omits a newline after "Log:".
>
> I'd call that a bugfix. A multi-line log message really should begin on its
> own dedicated line.

Er... what? I'd call that the introduction of a bug, for the very same reason.
  Note that the lines added are shown first, and the lines deleted are shown
afterwards.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 30 03:55:57 2006

This is an archived mail posted to the Subversion Dev mailing list.