[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19063 - trunk/subversion/libsvn_ra_serf

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-03-28 21:20:43 CEST

jerenkrantz@tigris.org writes:
> Modified: trunk/subversion/libsvn_ra_serf/ra_serf.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra_serf/ra_serf.h?pathrev=19063&r1=19062&r2=19063
> ==============================================================================
> --- trunk/subversion/libsvn_ra_serf/ra_serf.h (original)
> +++ trunk/subversion/libsvn_ra_serf/ra_serf.h Tue Mar 28 10:11:50 2006
> @@ -328,6 +328,22 @@
> serf_request_t*
> svn_ra_serf__request_create(svn_ra_serf__handler_t *handler);
>
> +/* XML helper callbacks. */
> +
> +typedef svn_error_t *
> +(*svn_ra_serf__xml_start_element_t)(void *baton,
> + const char *name,
> + const char **attrs);
> +

Please don't forget to document the semantics of these:-) Maybe
namespace handling could be pulled to this level as well?

> +typedef svn_error_t *
> +(*svn_ra_serf__xml_cdata_element_t)(void *baton,
> + const char *data,
> + apr_size_t len);
> +
There's no such thing as a "CDATA element". I suggest calling this
..._cdata_chunk to emphasize the fact that character data may be split
> arbitrarily

by the parser.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 28 21:21:18 2006

This is an archived mail posted to the Subversion Dev mailing list.