[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] was: More documentation for svn_utf_cstring_from_utf8_ex() etc.

From: Paul Burba <paulb_at_softlanding.com>
Date: 2006-03-24 20:43:28 CET

Original thread: http://svn.haxx.se/dev/archive-2006-03/1039.shtml

"Peter N. Lundblad" <peter@famlundblad.se> wrote on 03/23/2006 04:28:47
PM:

> Paul Burba writes:
> > I'm glad to do it, all I need to know is if folks want to do it
without
> > the API change or want svn_utf_cstring_*_utf8_ex revved.
> >
>
> I think it is fine not to rev it. We can get rid of this value if we
need to
> rev in the future, or in 2.0.
>
> Regards,
> //Peter

Here is my first stab at this.

While it isn't strictly necessary, I changed all callers to
svn_utf_cstring_*_utf8_ex() which passed a non-NULL convset_key to now
pass NULL. This makes it clearer to someone working on the calling code
that this argument is no longer relevant.

Let me know what you think.

Paul B.

[[[
Generate the keys used by svn_utf_cstring_*_utf8_ex (to cache
xlate_handle_node_t structs) based on the conversion taking place,
rather than using a string key passed to the function.

* subversion/include/svn_utf.h
   (svn_utf_cstring_to_utf8_ex, svn_utf_cstring_from_utf8_ex): Update
    doc strings.

* subversion/libsvn_repos/hooks.c
   (run_hook_cmd): Change calls to svn_utf_cstring_*_utf8_ex to pass
    NULL as convset_key arg.

* subversion/libsvn_subr/cmdline.c
   (SVN_UTF_CONTOU_XLATE_HANDLE, SVN_UTF_UTOCON_XLATE_HANDLE,
    SVN_UTF_ETOU_XLATE_HANDLE): Remove symbolic constants.
   (svn_cmdline_cstring_from_utf8, svn_cmdline_cstring_to_utf8,
    svn_cmdline__getopt_init): Change calls to
    svn_utf_cstring_*_utf8_ex to pass NULL as convset_key arg.

* subversion/libsvn_subr/io.c
   (SVN_UTF_UTOE_XLATE_HANDLE): Remove symbolic constant.
   (svn_io_create_unique_link, svn_io_read_link): Change calls to
    svn_utf_cstring_*_utf8_ex to pass NULL as convset_key arg.

* subversion/libsvn_subr/utf.c
   (svn_utf_cstring_to_utf8_ex, svn_utf_cstring_from_utf8_ex): Build
    unique convset_key for caching xlate_handle_node_t based on
    frompage/topage arguments.
]]]

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Mar 24 20:44:09 2006

This is an archived mail posted to the Subversion Dev mailing list.