[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Ruby test failure

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2006-03-19 12:36:08 CET

On Sun, Mar 19, 2006 at 10:38:19AM +0900, Kouhei Sutou wrote:
> This document is old for SWIG 1.3.28. For SWIG 1.3.28, if
> flags is 1, free function of the Ruby object is removed; if
> flags is 0, free function of the Ruby object isn't removed.
>

> The cause of the problem is that free function of Ruby's
> pool object is removed by SWIG_ConvertPtr() of SWIG 1.3.28.
> And the free function cleans up a lock in working copy.
>
> I fixed the problem by preventing a free function deletion.
>

Ah, I see. That makes more sense now, thanks!

> We don't have. We should check returned value.
> I added the code in r18951.
>

Okay, so now if r2c_swig_type2() fails, we will now raise an error,
but svn_swig_rb_get_pool() will still dereference pool_wrapper regardless,
won't it?

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 19 12:36:28 2006

This is an archived mail posted to the Subversion Dev mailing list.