[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: patch newline in log messages

From: Vincent Lefevre <vincent+svn_at_vinc17.org>
Date: 2006-03-02 03:18:48 CET

On 2006-03-01 12:09:24 -0600, kfogel@collab.net wrote:
> In Subversion today, it is possible (via the 'svn log' command) to
> recover *exactly* the log message the committer entered. This is
> because the addition of the extra newline is unconditional; if you
> just strip that newline, you get the original log message. With your
> patch, it is no longer possible to recover the exact log message,
> because the output of 'svn log' will not reveal whether an extra
> newline was added or not.
>
> I'm not saying this is horrible; indeed, I'm advocating a solution
> that has similar properties to your patch. However, there is no
> denying that it would simply not be possible to recover the original
> log data with your patch, because you can't know exactly where the
> original data ends. (I'm talking about via the command line client
> outpu -- obviously you could use direct APIs to get the log data).
>
> When I say "munge the data", what I mean is "make the exact original
> data unrecoverable". And what I said is true, but fortunately, the
> kind of munging we're talking about does not harm the meaning of the
> log message, so it may be permissible. It's still munging, however.

But is it important to recover the original log data? I don't think
it is. The server should do some form of normalization (I prefer this
term to "munging"), IMHO.

For instance, one could decide that the number of ending newline
characters must be fixed (choose either 0 or 1). I don't think it
makes sense to have a variable number of newline characters (when
this happens, it happens by accident).

Also, is the EOL for log messages always \n on the server, or does it
depend on the platform of the client that submitted the log message?
IMHO, it should always be \n (so that it can be correctly converted
on the client side when displaying the log). But if such a conversion
occurs, this is "munging" too. :)

-- 
Vincent LefŔvre <vincent_at_vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / SPACES project at LORIA
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 2 03:19:52 2006

This is an archived mail posted to the Subversion Dev mailing list.