[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] #9 OS400/EBCDIC Port: Running Hook Scripts

From: Paul Burba <paulb_at_softlanding.com>
Date: 2006-03-01 00:12:18 CET

Peter Lundblad <peter@famlundblad.se> wrote on 02/28/2006 03:09:16 AM:

> Because that'd be a deadlock:-) We create pipes to read the hooks'
> stderr output. We must read that output before waiting for the
> process, else the pipe buffers might fil up. (I think Paul's patch has
> the same problem.)

Philip Martin <philip@codematters.co.uk> wrote on 02/28/2006 05:12:30 PM:

> Paul Burba <paulb@softlanding.com> writes:
> First impression is that it's ugly. You have replaced the two
> functions svn_io_start_cmd and svn_io_wait_for_cmd with the single
> function svn_io_run_os400_cmd. I assume you did it like that because
> the two functions communicate via an apr_proc_t and that doesn't allow
> you to add extra data.
>
> Since this is a workaround for an APR bug I'm not sure why you chose
> to put a public function in libsvn_subr when the only caller is in
> libsvn_repos. Does the OS400 port support an external diff or
> external editor? Your patch doesn't seem to have addressed those.
>
> An alternative would be to modify the existing svn_io_start_cmd and
> svn_io_wait_for_cmd functions to pass svn_io_proc_t instead of
> apr_proc_t, this would allow you to add any extra data you need. I
> think svn_io_proc_t could be opaque and so all the OS400 stuff could
> be private to io.c. It would mean that the external diff/editor code
> get fixed as well, if that makes a difference.
>
> I feel a bit guilty about suggesting that since I seem to be asking
> for all your patches to be re-written :-/

Hi Gents,

Thanks for taking a look at this patch, I probably won't have time to
address your comments until Thursday.

Sorry for the delay, I'll get back to this soon, but I didn't want you to
think I was ignoring your comments!

Thanks,

Paul B.

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 1 00:12:47 2006

This is an archived mail posted to the Subversion Dev mailing list.