[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Eols are not preserved in DAV log reponse.

From: Alexander Kitaev <alex_at_tmate.org>
Date: 2006-02-28 19:27:04 CET

Hello Branko,

> There shouldn't be any \r's in the svn:log value in the first
> place; they're supposed to be filtered out by the client. So
> the first question is, where are they coming from?
I'm setting those messages programatically through JavaSVN (actually I'm
doing commit and commit message includes \r's). I understand your point and
agree that client should convert commit message not to contain \r's before
making a commit.

On the other side, as far as I understand, svn:log is not special kind of
property (except that it is set automatically on commit), so it should be
possible to set it to any value in any encoding or even binary data as well
as any other revision property (probably doing "svn propset -rX --revprop
svn:log -F fileWithWindowsEols" will do the same). Svnserve behaves
consistently here, preserving svn:log property value in log message, but
mod_dav_svn does not (the log message it reports is not same as the value
stored in revprop file of the corresponding revision).

I think behaviour of the mod_dav_svn and svnserve should be at least
consistent, otherwise one could get different log messages depending on the
protocol one uses; both shouldn't touch revision property values, leaving
eol convertion up to the client.

Alexander Kitaev,
TMate Software,
http://tmate.org/
http://jetbrains.com/tmate/

> -----Original Message-----
> From: Branko Cibej [mailto:brane@xbc.nu]
> Sent: Tuesday, February 28, 2006 19:14
> To: alex@tmate.org
> Cc: dev@subversion.tigris.org
> Subject: Re: Eols are not preserved in DAV log reponse.
>
> Alexander Kitaev wrote:
> > Hello All,
> >
> > I've noticed a difference between mod_dav_svn responses to
> > getRevisionProperty("svn:log") and log(...):
> >
> > Fetching revision property:
> >
> > <S:log>changes from 0.9.0 merged (1116:1155):&#13; &#13;
> > - export and swtich fixes&#13;
> > .....
> >
> > Fetching log (history):
> >
> > <D:comment>changes from 0.9.0 merged (1116:1155):
> >
> > - export and swtich fixes
> > .....
> >
> > As you could see, in "log" response real eols (those stored in
> > corresponding revprop file, in this case \r\n) are replaced
> with \n.
> > When using "svn" or "file" protocol, eols are reported
> correctly. Is this a known problem?
> >
> There shouldn't be any \r's in the svn:log value in the first
> place; they're supposed to be filtered out by the client. So
> the first question is, where are they coming from?
>
> -- Brane
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 28 19:47:52 2006

This is an archived mail posted to the Subversion Dev mailing list.