[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: patch newline in log messages

From: Olleg Samoylov <olleg_at_mipt.ru>
Date: 2006-02-28 00:01:04 CET

kfogel@collab.net wrote:
> Why is this a severe issue? The behavior is perfectly predictable.

Only for a subversion developer. :)
When a common user write a log message in a text editor, for instance
one line, user expect a one line log message, isn't it? After "svn log",
user is very surprised when see two line log message, especially text
string "|lines=2". This behaviour is unexpected and unpredictable for
everyone, except subversion developers. Do you agree?

This bug is not severe, but looked like an ink blot on a white shirt.

> I'm not yet convinced there is a bug here worth fixing. Since this
> thread's subject and body no longer contain the issue number, and

According to rules issue must be placed after a dispute in a mail thread.

> there is no description of your patch's behavior in your mail here,
> it's difficult for me to track down exactly what your patch does.

I'll explain. Log message in version 1.x may have (in case of text
editor) or may have not (in case of "svn ci -m") trailing newline. And
this is not issue of text editor, trailing newline is appeared after
removing "--This line, and those below, will be ignored--", this issue
is entirely of subversion.

Old "svn log" behavior is always add one newline more to insure text
will not be jammed.

After patch "svn log" will check for trailing newline in log message and
  only when it's needed add newline and increment "lines".

-- 
Olleg Samoylov

Received on Tue Feb 28 00:07:37 2006

This is an archived mail posted to the Subversion Dev mailing list.