[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: patch newline in log messages

From: <kfogel_at_collab.net>
Date: 2006-02-27 18:44:37 CET

Julian Foad <julianfoad@btopenworld.com> writes:
> OK, so Karl doesn't want his trailing newlines removed. Greg's quote
> is a conditional suggestion ("we would ...") out of context so it
> doesn't mean much by itself. These are only the opinions of certain
> people at a certain time, and don't necessarily mean that we will or
> won't do anything in particular.

I agree with what Julian says above. My opinion is just one
developer's opinion, even if it's a strong opinion. The developer
group could override it.

However, I do think Greg Hudson has the right idea: in the end, we
should treat log messages as a series of lines, and enforce the
convention that every line (including the last one) ends with a
newline.

> For example, if the problem is that you want consistent spacing at the
> end of each log message in your own repositories, here is one solution
> that may be acceptable to you and doesn't require changing Subversion
> at all: fix up all the old log messages, and write a pre-commit hook
> script that trims off or normalises any trailing newline(s) in the log
> message about to be committed.

+1 It's very easy to enforce whatever convention you want by using a
hook.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 27 21:02:31 2006

This is an archived mail posted to the Subversion Dev mailing list.