[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] #7 OS400/EBCDIC Port: Make svn_io_copy_file() CCSID insensitive.

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2006-02-25 01:22:16 CET

Mark Phippard wrote:
>>> On OS400 apr_file_copy() is sensitive to the source and destination
>>>
> files'
>
>>> CCSIDs in that it attempts to convert the contents of the source file
>>>
> from
>
>>> its CCSID to the CCSID of the destination file. If the files' CCSIDs
>>> differ from each other and/or the system CCSID, the destination file is
>>> likely to be corrupted.
>>>
>>>
>> That just made _me_ jump out the window. Luckily I'm on the second
>> floor, it was only a 6m drop.
>>
>
> I do not know if you were joking or not, in response to Paul's comment
> about Julian, but we checked with IBM on this function and they are just
> implementing the exact function from the normal APR. APR does not open
> either of the files as binary, so on OS/400 that means it will try to
> translate the contents as it is Read and Written.
>
> I guess other platforms do not have this issue? I thought there were some
> differences in text and binary mode though, doesn't it effect line endings
> or something? Why would the APR function never corrupt files on other
> platforms? Why does APR not have a binary copy option? My guess, is that
> is _is_ binary on other platforms, but if that is the case, why doesn't it
> just specify APR_BINARY when it opens the files?
>
APR_BINARY has no effect on Windows or Unix, as far as I know. APR does
_not_ do end-of-line conversion on file contents, so APR_BINARY and its
documentation is a bit misleading.

The question is, then, whether the OS/400 port of APR is correct in not
using APR_BINARY in apr_file_copy or not.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 25 01:23:34 2006

This is an archived mail posted to the Subversion Dev mailing list.