[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Diffs for running svnserve as a Win32 service

From: Arlie Davis <adavis_at_stonestreetone.com>
Date: 2006-02-24 23:03:18 CET

Ok, so tell me what you would consider sufficient for this patch. Again, I
would LOVE to be able to shut down svnserve cleanly, and I have already
structured the code around this, so that any future developer that DOES
provide clean shutdown can see clearly how to integrate it with the service
support.

So tell me how to do it.

Otherwise, I don't see how this is a rational objection to taking this
patch.

-- arlie
 

-----Original Message-----
From: rooneg@gmail.com [mailto:rooneg@gmail.com] On Behalf Of Garrett Rooney
Sent: Friday, February 24, 2006 4:57 PM
To: Arlie Davis
Cc: Ivan Zhakov; dev@subversion.tigris.org
Subject: Re: Diffs for running svnserve as a Win32 service

On 2/24/06, Arlie Davis <adavis@stonestreetone.com> wrote:
> You are distorting what I said. Last week, I asked the list for
> information on cleanly shutting down the service. I got no responses,
> and from analyzing the code, there simply *is* no clean way to stop
> svnserve. On Unix, SIGQUIT will terminate the process. On Win32,
> Control-C will terminate the process.

You got no answer because currently there is no way to do it.

> When I implemented the service support, I had to choose to do
> *something* with the "stop service" request. I chose a method that
> was *more* polite than what the current svnserve implementation. So
> I'm a little insulted that you think I'm "bending over backwards to do
> something the wrong way", since my implementation is marginally
> *better* than what svnserve does, right now.
>
> I repeat -- if someone can tell me how to *cleanly* shut down
> svnserve, I will happily add that support to the feature. The support
> is already there
> -- the only that is necessary is for svnservice_notify_stop to do
> something more productive than what I have provided.

All I'm saying is that if the Win32 service code requires the ability to
shut down svnserve gracefully, then that feature should be added in such a
way that it can be used on systems other than Win32. You seem to have gone
through a great deal of trouble to peek under the covers of APR and insert a
platform specific hack to make this work, what I would prefer would be to
avoid the need to do that and just make the (maybe fairly small) change to
svnserve itself to make it possible to shut it down via a signal or
something.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 24 23:02:31 2006

This is an archived mail posted to the Subversion Dev mailing list.