Re: svnauthz-validate.c: Tool to validate authz files

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Rall wrote:
> Thanks Lieven, looks neat. Should we stick this in the contrib area?
>
> - Dan

I'm inclined to put it under tools - it's small enough and useful enough
that providing the greater level of maintenance implied by tools vs.
contrib isn't going to be a problem.

Though, I would like to see a few things fixed first:

Compile command:
Does not need apache include files or libraries.
Does not need to link libsvn_client
DOES need to link libsvn_repos and libsvn_subr

Usage message:
s/when/if/
What does it return if content is not ok?

Actually, it would be nice if it could return:
0 => Syntax OK
1 => Syntax Bad, no other error
2 => Operational error
(Drop usage of the EXIT_SUCCESS|FAILURE defines entirely, since they
don't really make sense unless you are using them exclusively.)

Should not pass "minimal_client" to svn_cmdline_init().

Remove the very elementary comments inherited from minimal_client.

Remove the "shouldn't I clean the pool object here" comment. Call
svn_pool_destroy(pool); apr_terminate(); to illustrate good practices.

Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFD9aGufFNSmcDyxYARAlZOAJ95nMml1Q+0yyhDK9u5x1D85aM37wCgkywO
qbFlr0mkm2x8SBVRxwHgSWs=
=59mc
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 17 11:18:47 2006