[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18486 - trunk/subversion/libsvn_ra_serf

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2006-02-17 09:22:47 CET

On 2/17/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> Huh? What makes the #define hard to change? (Well, in principal, this can
> wait; I just don't follow your reasoning...)

There are many variants of this loop that call into bucket_read.
Therefore, one global value would not be appropriate for all requests
that we'll have to make - some transactions have smaller and larger
bodies, some have better streamy semantics from the server than
others, some have more explosive memory characteristics, etc.
Therefore, each variation would ultimately need its own #define and
keeping track of that - since a #define would be separated from the
actual loop into a header file (meaning every time I tweak it,
everything in the library needs to be recompiled) - is what I feel
isn't right at this early stage. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 17 09:24:35 2006

This is an archived mail posted to the Subversion Dev mailing list.