[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Ignoring space changes, but not all space changes

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-02-17 08:52:02 CET

On Fri, 17 Feb 2006, Ph. Marek wrote:

> On Thursday 16 February 2006 23:27, Julian Foad wrote:
> > In languages like C, what we need is:
> >
> > Ignore spaces completely when they're between tokens that don't
> > concatenate; ignore changes to the nonzero amount of space where tokens do
> > concatenate.
> >
> > The sets of tokens that do and do not concatenate are language-specific.
>
> I see lots of problems ahead.
...
>
>
> I believe that this should be solved like the diff-issue, ie. done by specific
> diff-programs, which get chosen based on the mime-type or the file(1) result.

I think it is fine to have the basic functionality that I committed
yesterday. It has been in (GNU?) diff for years and people seem to use
it.

> Note: I'm not sure how much work for blame is done on the server - but if the
> comparisions are done there, all needed diff-programs would have to be
> installed there, too.
>
The diff is run on the client, but always using the internal diff program.
If we allow external diff programs to be plugged into blame, we'd need to
start parsing (various!) diff romats and hope for the best...

> Sure, you could expand the internal diff with various options, but that'll get
> you only part of the way ... a full solution would have to know about the
> file-type.

I don't want to go adding lots of whitespace handling options to
libsvn_diff.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 17 08:54:50 2006

This is an archived mail posted to the Subversion Dev mailing list.