[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue 1780: Keyword values with dollar signs causebadness.

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-02-15 02:23:24 CET

Lieven Govaerts wrote:
> Aha, this makes sense, and explains why random replacing of code didn't
> trigger the tests to fail.
[...]
> The new tests seem to confirm your assumption on
> how the algorithm should behave, so I include them in the attached patch.

I've committed this as r18465, with just a small tweak (I changed a "*len"
parameter to "len" where it was used only as input).

Thank you very much for your work.

Other folks, should I close issue #1780 ("Keyword values with dollar signs
cause badness"), saying something like:

> Committed a patch by Lieven Govaerts that mostly fixes this (r18465). Any '$'
> signs in a keyword value are handled correctly except as the first character or
> immediately after a space, which is all that can be done without a quoting
> mechanism.
>
> This fix covers most likely occurrences, and therefore I'm marking this issue as
> fixed. If some more extensive fix is desired, perhaps involving an escaping
> mechanism or limiting the set of valid keyword values, that should be filed as a
> separate enhancement.

... or should I leave it open, changing it to Enhancement and perhaps lowering
the priority or setting the target milestone to "2.0"?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 15 02:24:23 2006

This is an archived mail posted to the Subversion Dev mailing list.