[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn diff --summarize

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-02-12 16:55:06 CET

Garrett Rooney wrote:
> On 2/9/06, Julian Foad <julianfoad@btopenworld.com> wrote:
>
>>Can anybody shed light on whether this is a deficiency that can reasonably be
>>fixed? If not, maybe the "diff --summarize" feature (including the API) will
>>not be able to support copyfrom info.
>
> Diff simply does not send copyfrom data, that's one of the reasons I
> wrote ra_replay.

I see.

Eventually I expect we will want "diff" to provide that info, so that someone
can implement an svn-aware diff and patch pair; however, that's not likely to
happen soon. Therefore we'd better remove that apparent capability from the
diff-summarize API before it gets released in v1.4. Sorry Martin; please could
you send a patch for that.

I couldn't find it documented that those parameters to the editor callbacks are
not filled in by a diff. Would svn_ra_do_diff2() be the place? Presently it says:

svn_ra_do_diff2():
> * When finished, the client calls @a reporter->finish_report(). The
> * RA layer then does a complete drive of @a diff_editor, ending with
> * close_edit(), to transmit the diff.

Should we add here, "Copy-from information is not supplied to the editor
callbacks." ?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 12 16:55:44 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.