[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 'svnadmin load' doesn't detect premature end of dump stream

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-02-07 01:59:58 CET

On 2/6/06, Julian Foad <julianfoad@btopenworld.com> wrote:

> The attached patch adds missing checks for premature EOF. Does it look sane?

The only comment I have is that wrappers like the stream_ran_dry
function are evil because they make the file/line info for an error
useless, and if you can remove their used where you see them and
replace with macros instead it would make the world a better place.
Other than that looks fine.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 7 02:00:23 2006

This is an archived mail posted to the Subversion Dev mailing list.