[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Experimental svn diff -w

From: Sander Striker <striker_at_apache.org>
Date: 2006-02-05 15:39:03 CET

Peter N. Lundblad wrote:
> On Fri, 3 Feb 2006, Sander Striker wrote:
[...]
> I reallized that the output routines don't make use of the chunks read by
> the token reading functions, so I'll normalize once when reading the
> chunks.

+1.

[...]
>> I wonder if we want options to our own code to be passed with -x.
>> I can see it for eXternal commands.
>
> I'm not entirely comfortable with -x/--extensions being used as if our own
> diff library was some external applications.

Yes, that's what I felt too.

> My concern is, besides rooneg's good point about being able to use the GNU
> diff option names, that we may bloat our own "option space", especially if
> we want more diff options later.

While this is true, I feel that we are jumping through hoops to not have
subcommand specific options. In case of diff, merge (and maybe blame) these
are almost unavoidable (with exception of the long option names ofcourse).

>>>--strip-trailing-cr (maybe)
>>
>>Hmm, in that case I would say go for --ignore-eol-style.
>
> I'm wondering what exactly the semantics would be. Treat all line endings
> as the platform line endings, or treat all line endings as LF?

What's the difference? On comparison they will be the same in both
cases no? In that light normalizing to LF seems easiest, but
that's a meer implementation detail.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 5 15:52:42 2006

This is an archived mail posted to the Subversion Dev mailing list.