Hi Brane,
The plink does not seem to be accepting -p(small p) rather accepts
-P(capital p) as a port.
Yes the same 16 tests(I sent to Karl's response) are failing even with
the current head without my patch.
May be mine is a VPATH based build which could be the cause. Will test
Non-VPATH build and post the result.
Will post the patch with a corresponding doc changes tomorrow.
Thanks
With regards
Kamesh Jayachandran
Branko Čibej wrote:
> Kamesh Jayachandran wrote:
>> Hi All,
>> I hereby attach patch for #1942.
>>
>> Ran make check/make autodavcheck found nothing alarming.
>> Ran make svnsshcheck found 16 tests failing with and without this
>> patch and hence attribute the failures to out of date work area and
>> submit this patch.
> You mean you didn't actually check why those tests were failing?
> That's not nice at all.
>
>> [[[
>> Fix issue #1942, svn+ssh should use the port value
>>
>> Patch by: Kamesh Jayachandran <kamesh@collab.net>
>>
>> * subversion/libsvn_ra_svn/client.c
>> (find_tunnel_agent) Modified to accept the apr_uri_t*
>> rather than hostinfo so that we can make use of the
>> port information available in apr_uri_t.
>> This port is given as -p to ssh binary in case available.
>>
>> ]]]
> You forgot to mention the change in the function where
> find_tunnel_agent is called.
>
>> + if (uri->port_str != NULL)
>> + {
>> + (*argv)[n++] = "-p";
>> + (*argv)[n++] = uri->port_str;
>> + }
>>
> What if the tunnel agent isn't SSH? Plink on Windows will accept a -p
> options, but you can configure other kinds of tunnel agents.
>
> Also, this changes the interface between the Subversion client and
> tunnel agents. This change should be documented somewhere, probably in
> the ~/.subversion/config template.
>
> -- Brane
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 1 14:15:38 2006