[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18291 - in trunk/subversion: libsvn_wc tests/cmdline

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2006-01-30 18:27:04 CET

On Mon, Jan 30, 2006 at 08:40:40AM -0600, kfogel@collab.net wrote:
> Sure that would be futureproof, but it could mask unexpected error
> situations. If parent_status->entry were NULL, we'd just blithely
> skip along, without having any idea why it was NULL or what that might
> signify. I feel like it's better to enumerate the expected
> conditions, because that means we understand what's going on in the
> code (or, as in the current case, it alerts us to when we don't
> understand it well enough).
>

I haven't even looked at the surrounding code, so that might make it
cleaerer; it just seemed odd that the comment seemed to suggest that the
only way to avoid dereferencing a NULL pointer is to first consider all
the possible reasons that it might have for legitimately being NULL.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 30 18:31:41 2006

This is an archived mail posted to the Subversion Dev mailing list.