Re: r17333 backport for 1.3.x

Malcolm Rowe wrote:
>
> Ok, I've been trying to review the backport of r17333 for 1.3.x, and
> I'm a little confused.

The log message for r17333 is:

> r17333 | dionisos | 2005-11-14 19:20:52 +0000 (Mon, 14 Nov 2005) | 12 lines
>
> Fix issue #2306 - really.
>
> Patch by: [...]
>
> * subversion/libsvn_wc/log.c (file_xfer_under_path): Make sure
> detranslation source and target do not point to the same file. If
> they do, use an intermediary temp file.

Please could someone (dionisos?) make it say what bug it is fixing (not just by
mentioning the issue number), and clarify that word "really" which implies to
me that a previous attempt had been made and failed. A log message should be
basically understandable without access to the issue tracker even if many
important additional details are in the tracker.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 27 15:05:28 2006