[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18204 - trunk/contrib/hook-scripts

From: Martin Tomes <lists_at_tomes.org>
Date: 2006-01-26 10:02:18 CET

Philip Martin wrote:
> martinto@tigris.org writes:
>> Author: martinto
>> Date: Tue Jan 24 10:16:30 2006
>> New Revision: 18204
>> Log:
>> * contrib/hook-scripts/case-insensitive.py:
>> Output the 'clash' text as utf-8, previously ascii was used and
>> non-ascii characters in files names caused the error message at the
>> subversion client to read 'svn: General svn error from server'.
>> Non ascii names such as bc.txt and bc.txt are now displayed at
>> the client when they clash.
>
> Forcing the hook script to output UTF-8 is not correct, hook scripts
> are supposed to output in the native encoding[1]. The first thing that
> libsvn_repos does with the hook output is convert from the native
> encoding to UTF-8, it makes no sense for the hook to output UTF-8
> unless the native encoding is also UTF-8. I believe the original code
> was correct.
>
> [1] httpd might be an exception since it doesn't set up the locales,
> in that case hook scripts probably need to restrict their output
> to plain ascii.

Would it be possible to detect whether the hook script is being fired
off from apache or svnserve? We have companies in France and Italy
using Subversion so this hook really should detect non-ascii case conflicts.

-- 
Martin Tomes
echo 'martin at tomes x org x uk'\
  | sed -e 's/ x /\./g' -e 's/ at /@/'
Visit http://www.subversionary.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 26 10:02:46 2006

This is an archived mail posted to the Subversion Dev mailing list.