Re: [PATCH] Introduce new build.conf option "sourcelibs"
On 12/13/05, Branko Čibej <firstname.lastname@example.org> wrote:
> Ivan Zhakov wrote:
> > On 12/5/05, Ivan Zhakov <email@example.com> wrote:
> >> Hi!
> >> I am working on building Windows Subversion DLLs (issue 1627). When
> >> this work will be finished, we cannot build some tests because they
> >> call internal functions that will not be exported by DLLs.
> >> So I am going to commit Russell Yanofsky's patch that introduce new
> >> build.conf option "sourcelibs". Libraries listed in this option will
> >> be linked directly by sources.
> I wish you hadn't done this.
> As I said in several other posts now and in the past, I expect the
> Windows DLLs to be build by a simple relink of the static libraries --
> *not* as a complete separate target (or, worse MSVC "configuration").
> If we do this, then we can simply link the unit tests with the static
> libs, and link the command-line utilities with the DLLs -- the tests
> will be valid since both variants of the library contain identical code.
> I think this is much better than complicating the build system with
> source vs. library link optins, and we _do_ want to build both the
> static and the dynamic libraries.
> (I'm not sure whether we want to provide completely statically-linked
> versions of the command line tools by default.)
I've reverted it in r18221.
Received on Wed Jan 25 14:32:59 2006
This is an archived mail posted to the Subversion Dev