[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix crash when copying added files with --force

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-01-06 20:42:37 CET

On 1/6/06, Stefan Küng <tortoisesvn@gmail.com> wrote:

> Ok, I've got a recipe on how to provoke the crash.
> Using svn version 1.3.0 (my own build, since the official windows
> binaries aren't available yet):
>
> $ cd some_working_copy
> $ echo sometext > file
> $ svn copy file file2
> ==> crash
>
> The problem is that in line 526 of file libsvn_wc/copy.c, the
> 'src_entry' is NULL, so the 'if' check
> if ((src_entry->repos ...
> causes an exception.
>
> I guess a fix would be quite easy, but I'm not sure if you'd rather have
> a check for (src_entry != NULL && dst_entry != NULL) or if you'd like to
> have the call to svn_wc_entry() in the line above to return an error.
>
> May I also say that a fix for this is quite important: the RC1 release
> of TSVN is out only for about a week, and I've already received 9
> crashreports with exactly that crash. And considering it's an RC and the
> first week of the year where many people are still on holiday, that's
> quite a high number.

I can reproduce this here, although it seems to be fixed in trunk
(wc-replacements probably changed this codepath). I'll look at
getting a fix together and into 1.3.x for the next release.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 6 20:48:56 2006

This is an archived mail posted to the Subversion Dev mailing list.