[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] fix crash when copying added files with --force

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-01-05 21:19:49 CET

Hi,

The first crashreports for TortoiseSVN 1.3.0RC1 are coming in :)

When copying added (but not committed yet) files with the --force flag,
Subversion crashes in libsvn_wc/copy.c, line 515.
That's because there are (IMHO) bogus brackets in the check there.

Attached is a patch which fixes this issue.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org

[[[
Fix crash when added files are copied with --force.
* subversion/libsvn_wc/copy.c:
  remove bogus brackets.
]]]
Index: subversion/libsvn_wc/copy.c
===================================================================
--- subversion/libsvn_wc/copy.c (Revision 17990)
+++ subversion/libsvn_wc/copy.c (Arbeitskopie)
@@ -511,7 +511,7 @@
        _("'%s' is not under version control"),
        svn_path_local_style (src_path, pool));
 
- if ((src_entry->repos != NULL && dst_entry->repos != NULL) &&
+ if (src_entry->repos != NULL && dst_entry->repos != NULL &&
       strcmp (src_entry->repos, dst_entry->repos) != 0)
     return svn_error_createf
       (SVN_ERR_WC_INVALID_SCHEDULE, NULL,

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 5 22:11:29 2006

This is an archived mail posted to the Subversion Dev mailing list.