[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: MD5 backward compat code?

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2005-12-09 13:05:47 CET

On 12/9/05, Erik Huelsmann <ehuels@gmail.com> wrote:
> In in libsvn_wc/adm_crawler.c:svn_wc_transmit_text_deltas() the MD5
> checksum is checked against a hex representation, but as a fallback
> for pre-Jan 2003 WCs it also compares against a base64 encoded md5.
>
> The checksum-check in libsvn_wc/questions.c:compare_and_verify() -
> which also may need to compare 'old' checksums - doesn't have this
> fallback.
>
> I think this is strange, especially since compare_and_verify() is used
> by svn_wc_text_modified_p, which is typically called before a commit
> is started - and thus before svn_wc_transmit_text_deltas() is called.
>
> I'd like to remove the fallback from svn_wc_transmit_text_deltas(),
> also because it is a backward compat to pre-1.0 working copies. I
> think the time to update those to post 1.0-working copies has elapsed
> :-)
>
> (Being able to eliminate the fallback would also greatly simplify a
> change I have in mind for svn_wc_translate_text_deltas()...)
>
> Comments?
+1, please do it.

--
Ivan Zhakov
Received on Fri Dec 9 13:08:01 2005

This is an archived mail posted to the Subversion Dev mailing list.