[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Building JavaHL on OS X

From: Daniel Rall <dlr_at_collab.net>
Date: 2005-12-07 02:29:11 CET

On Tue, 06 Dec 2005, Malcolm Rowe wrote:

> On Mon, Dec 05, 2005 at 09:46:49PM -0500, David James wrote:
> > On 12/3/05, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> > > + if test "$os_arch" = "Darwin"; then
> > > + JRE_LIB_DIR="/System/Library/Frameworks/JavaVM.framework/Classes"
> > > + else
> > > + JRE_LIB_DIR="$JDK/jre/lib"
> > > + fi
> >
> > Perhaps use this test instead, to be consistant with the test for
> > /Library/Java/Home?
> > if test "$os_arch" = "Darwin" -a "$JDK" = "/Library/Java/Home"; then
> >
> > I'm not familiar with Mac OS X, but I'd guess that if $JDK is in a
> > non-standard location, then we'd be better off using "$JDK/jre/lib"
> > than the standard location for $JRE_LIB_DIR.
> >
>
> Sounds sensible to me. I can't test at the moment, but I'm fairly sure
> that should work.

+1, I like David's additional suggestion. Malcom, if you would,
please commit.

- Dan

  • application/pgp-signature attachment: stored
Received on Wed Dec 7 02:27:37 2005

This is an archived mail posted to the Subversion Dev mailing list.