[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17572 - in trunk/subversion: libsvn_ra_dav libsvn_repos libsvn_subr

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-12-01 00:03:44 CET

On Wed, 2005-11-30 at 17:48 -0600, dionisos@tigris.org wrote:
> Create a subpool to allocate SVN_STREAM_CHUNK_SIZE buffers. Just before
> completing successfully, clean the subpool to free the 100kB buffer.

I don't understand the need for this. If the function is being called
in a loop, the loop should be using an iteration pool. If the function
is not being called from a loop, 100K is noise.

If the functions return allocated information, that might make it worth
doing large temporary allocations in a subpool. You didn't include any
symbol names in your log message, so I can't easily tell whether you
modified functions of that nature.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 1 00:04:50 2005

This is an archived mail posted to the Subversion Dev mailing list.