Re: Shutting up warnings (was: Re: [wc-propcaching] Use of uninitialized variable (libsvn_wc/props.c))

> > if (props_p)
> > {
> > if (has_propcaching && ! entry->prop_mods && entry->has_props)
> > - *props_p = apr_hash_copy (pool, base_props);
> > + *props_p = base_props
> > + ? apr_hash_copy (pool, base_props) : apr_hash_make (pool);
>
> If I'm not missing something (which might well be true, since I wrote this
> code), base_props can never be NULL here. I think it is confusing to add
> code that will never be executed. (An assert is better if that's desired.)

Hmm. Sorry, ofcourse you're right there.

>
>
> > else if (! has_propcaching || entry->has_props)
> > {
> > const char *prop_path;

bye,

Erik.
Received on Mon Nov 21 13:49:16 2005