[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH} move and extend 'svnversion' functionnality in libsvn_wc

From: Fabien COELHO <fabien_at_coelho.net>
Date: 2005-11-14 15:47:00 CET

Hello,

> Yes, it seems like a good idea to move that function into a library.
>
> However, your patch does not just move it; your patch also extends it.
> Please split this into two separate patches. (Obviously it will matter which
> one is applied first.)

That can be done.

> For the patch that extends the functionality of svnversion, please say what
> the extensions are and why you want them.

Two patches would change the signature of the result structure introduced
added to libsvn_wc. Isn't it an issue that the signature of a library
function is changed twice in two patches? No problem with me, just that I
would expect lib functions to be very stable.

-- 
Fabien.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 14 15:50:30 2005

This is an archived mail posted to the Subversion Dev mailing list.