[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Refactor install_file

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2005-11-12 00:36:13 CET

On 11/11/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> Hi,
>
> I've spent the last few days trying to make install_file in
> libsvn_wc/update_editor.c a bit more managable. This is a complex piece
> of software in itself. Here is a patch that does som refactoring. It
> passes tests (over DAV to test wcprops), of course, but I really would
> appreciate some other people's review.
>
> This could probably be refactored even more, and we know there are bugs in
> install_file. I'm not trying to fix bugs in this round.
>
> I'm not going to commit this until earliest Sunday evening (UTC+2). If
> anyone wants to work in this area during the weekend and thinks the patch
> is OK, feel free to commit.
I have looked to your patch and didn't find any errors. Patch looks
very good for me. Also it passes all test on Windows (only local
fsfs).
I have only one thought: what about rename install_file to merge_file?
It looks more realistic.

--
Ivan Zhakov
Received on Sat Nov 12 00:37:26 2005

This is an archived mail posted to the Subversion Dev mailing list.