On 10 Nov 2005 14:01:54 -0800, C. Michael Pilato <cmpilato@collab.net> wrote:
> Someone recently reported that very piece of code as a bug (issue #2433).
>
> Erik Huelsmann <ehuels@gmail.com> writes:
>
> > Because I'm working on simplifying libsvn_wc, I'm working on
> > (de)translation routines. Wondering what the actual Repository Normal
> > Format for eol style is, I read:
> >
> > http://svn.collab.net/repos/svn/trunk/notes/line-endings-and-keywords.txt
> >
> > which says it is 1 out of 3 possibilities:
> >
> > 1) no eol-style set: do nothing
> > 2) fixed eol-style set: translate (repairingly) to that style
> > 3) native is set: translate to LF, fail on mixed eols
> >
> > libsvn_wc implements this scheme in at least svn_wc_translated_file2().
> >
> > But looking at libsvn_client/commit.c:108 (send_file_contents) [ at
> > http://hix.nu/subversion/lxr/source/subversion/libsvn_client/commit.c#108
> > ], we have a different scheme.
> >
> > So, which is it supposed to be?!
> >
> > If send_file_contents is correct, then shouldn't libsvn_wc be adjusted?!
> >
> > bye,
> >
> >
> > Erik.
Ok. Looking into this a bit more, I see why only import has this
problem: only import uses send_file_contents. All other code uses
svn_wc_translated_file, which does this correctly.
Anyway, thanks for the pointer, I think I can safely change the code
to 'do what svn_wc_translated_file does' and maybe call the issue
fixed.
bye,
Erik.
Received on Thu Nov 10 23:16:58 2005