On Fri, 2005-11-04 at 02:20, Philip Martin wrote:
> Madan U Sreenivasan <madan@collab.net> writes:
>
> > +#----------------------------------------------------------------------
> > +def removal_schedule_added_props(sbox):
> > + "removal of schedule added file with properties"
> > +
> > + sbox.build()
> > +
> > + wc_dir = sbox.wc_dir
> > + newfile_path = os.path.join(wc_dir, 'newfile')
> >
> > + # create new fs file
> > + touch_command = "touch " + newfile_path
> > + os.system(touch_command)
>
> Don't use os.system, use file_append.
>
> > + svntest.main.run_svn(None, 'add', newfile_path)
>
> Please try to avoid run_svn, run_and_verify_svn is better.
>
> > + svntest.main.run_svn(None, 'propset', 'newprop', 'newvalue', newfile_path)
>
> It would be good to run a proplist command to verify that the property
> has been set successfully. Perhaps use run_and_verify_status as well.
Okay, as I understand, the test has to be more robust, in terms of
checking if the preconditions are created properly. I will have to
rewrite the test. Will do that.
Thanks for the review.
Regards,
Madan.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 3 23:57:38 2005