[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] add 'svn version' as 'svnversion' v1

From: Fabien COELHO <fabien_at_coelho.net>
Date: 2005-11-02 11:32:15 CET

Dear SVN developers,

MOTIVATION

I find it irritating to have a separate command to check for the revision
heterogeneity of a local working copy. The rationnal for 'svnversion' as
given in the source file is that it could have been used in the svn
building process. Well, it is not, and svnversion does still exists anyway
after this patch.

APPLY tosvn trunk:

sh> svn cp subversion/svnversion/main.c subversion/clients/cmdline/version-cmd.c
sh> patch < svn_version_cmd.patch
sh> ./autogen.sh

MESSAGE

Create a 'version' subcommand so that 'svn version' behaves as 'svnversion' does.

FILES
M subversion/clients/cmdline/cl.h
A + subversion/clients/cmdline/version-cmd.c
M subversion/clients/cmdline/main.c
M tools/client-side/bash_completion

QUESTIONS

I'm not so sure about the details in my patch:

  - is it really worth creating a subpool for that? If so, is it done well?

  - could the functionnality be moved to some library and invoked there
    by both 'svn' and 'svnversion'? If so, which one?

  - would the subcommand be better named 'revision/revisions' or some other
    name? Here there is a subcommand and an option with the same name...

  - are there other files that should be fixed as well?

  - what about 'svn rm subversion/svnversion'?
    add svnversion = exec svn version as a substitute?

-- 
Fabien.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Wed Nov 2 11:34:12 2005

This is an archived mail posted to the Subversion Dev mailing list.