[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17024 - trunk/subversion/tests/clients/cmdline

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-10-26 09:49:17 CEST

On 10/26/05, dionisos@tigris.org <dionisos@tigris.org> wrote:
> Modified:
> trunk/subversion/tests/clients/cmdline/revert_tests.py
>
> Log:
> Add test for 'revert in current directory'.
>
> Note: This test shows current trunk breakage (a wc-replacements regression)
>
> * subversion/tests/clients/cmdline/revert_tests.py
> (revert_from_wc_root): Revert a number of files+dirs where '.'
> is a wc root.

The merge from wc-replacements broke this test. After investigating, I
found it to be related to the prop-path calculation in
adm_ops.c:revert_admin_things().

Zhakov: would it be an idea to stop passing adm_access (which is only
used to determine if 'path' is a directory), instead passing a boolean
is_dir, which can be used for the same purpose. The caller then will
be responsible to do the type-determination.

The net result being that prop_path_internal can do either full or
relative path calculations without a need for new functions or even
the current path calculations in revert_admin_things.

bye,

Erik.
Received on Wed Oct 26 09:50:41 2005

This is an archived mail posted to the Subversion Dev mailing list.