[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RFC: an idea for making 'svn list' faster

From: egoots <egoots_at_gmail.com>
Date: 2005-10-24 01:27:05 CEST

On 10/22/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> On Fri, 21 Oct 2005, Justin Erenkrantz wrote:
>
> > --On October 21, 2005 3:38:13 PM -0700 Garrett Rooney
> > <rooneg@electricjellyfish.net> wrote:
> >
> > >... So I'd like to propose a new
> > > svn_ra_get_dir2 function, which takes a new argument that indicates
> > > what parts of the dirent you get back from the server. It'd look
> > > something like this.
> > >
> > ># define SVN_DIRENT_FIELD_KIND = 0x00001;
> > ># define SVN_DIRENT_FIELD_SIZE = 0x00002;
> > ># define SVN_DIRENT_FIELD_HAS_PROPS = 0X00004;
> > ># define SVN_DIRENT_FIELD_CREATED_REV = 0X00008;
> > ># define SVN_DIRENT_FIELD_TIME = 0X00016;
> > ># define SVN_DIRENT_FIELD_LAST_AUTHOR = 0X00032;
> >

Is svn_ra_get_dir2( ) intended to return various combinations of the
above fields by OR'ing them together? If so, shouldnt the constant
field values have unique bits set? For example, shouldnt they be
something like:

#define SVN_DIRENT_FIELD_KIND = 0x00001; // binary 0000 0001
#define SVN_DIRENT_FIELD_SIZE = 0x00002; // binary 0000 0010
#define SVN_DIRENT_FIELD_HAS_PROPS = 0X00004; // binary 0000 0100
#define SVN_DIRENT_FIELD_CREATED_REV = 0X00008; // binary 0000 1000
#define SVN_DIRENT_FIELD_TIME = 0X00010; // binary 0001 0000
#define SVN_DIRENT_FIELD_LAST_AUTHOR = 0X00020; // binary 0010 0000

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 24 01:28:02 2005

This is an archived mail posted to the Subversion Dev mailing list.