[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_wc_external_item_dup parameter names

From: David James <james82_at_gmail.com>
Date: 2005-10-23 08:53:37 CEST

On 10/22/05, Julian Foad <julianfoad@btopenworld.com> wrote:
> There's a mismatch between the prototype and the definition of
> svn_wc_external_item_dup(), introduced in r16772 and ported to 1.3.x in r16791:
>
> > Index: branches/1.3.x/subversion/include/svn_wc.h
> > ===================================================================
> [...]
> > /**
> > + * Return a duplicate of @a item, allocated in @a pool. No part of the new
> > + * item will be shared with @a item.
>
> Here: "item".
>
> > + *
> > + * @since New in 1.3.
> > + */
> > +svn_wc_external_item_t *
> > +svn_wc_external_item_dup (const svn_wc_external_item_t *entry,
>
> Here: "entry".
>
> > + apr_pool_t *pool);
>
> > Index: branches/1.3.x/subversion/libsvn_wc/util.c
> > ===================================================================
> [...]
> > +svn_wc_external_item_t *
> > +svn_wc_external_item_dup (const svn_wc_external_item_t *item, apr_pool_t *pool)
>
> Here "item".
>
>
> It's legal C but obviously not what we meant. I have no preference on which
> way to resolve it.
Good catch, Julian! I really appreciate your attention to detail.

I've fixed this in r16929 by using the parameter name "item"
consistently. Should we nominate this for backport as well?

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james
Received on Sun Oct 23 08:54:18 2005

This is an archived mail posted to the Subversion Dev mailing list.