[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Seeking JavaHL developers for RC

From: Marc Sherman <msherman_at_projectile.ca>
Date: 2005-10-21 00:14:24 CEST

Branko Čibej wrote:
>>
> For what you describe, you _definitely_ need the _is_ version of the
> API. effetively, you want to do what libsvn_wc does; actually use either
> _svn or .svn, but treat both as special names (e.g., even if the .net
> hack is enabled, you still can't "svn mkdir .svn").
>
> Reading this discussion, I'm now really sorry I ever provided the _get_
> form.

Brane, I think you've misunderstood what happens in Subclipse. The is_
api can only replace direct string comparisons in the Subclipse code.
However, there are places where Subclipse must pass the admin dir names
in to Eclipse code, that is not controlled by the plugin, so those
places cannot be modified to call the is_ api to replace the string
comparison.

>> I do not think we ever have a case where we have some folder name and
>> we want to check if is an admin directory or not.
>>
> I definitely hope client code doesn't do that...

As Mark pointed out later in the thread, there is in fact client code
that needs to do that, in order to suppress indexing/browsing/display of
the folder in the project tree. And that's done by the Eclipse core,
not by the Subclipse plugin, so a get_ api that returns all possible
admin dir names is what's really needed.

In the interim, for 1.3 release, it's probably acceptable for Subclipse
to be modified to always register ".svn", and conditionally also
register the return of the get_ api, if it's different from ".svn".

- Marc

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 21 00:15:07 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.