[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] commit-email.pl.in bugs

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-10-18 23:52:25 CEST

Thanks Jim, committed to trunk in r16801. I've nominated this for backport
into the 1.3.x line, but it may or may not make it into 1.3.0.

On Mon, 17 Oct 2005, Jim Paris wrote:

> The previous two commits to tools/hook-scripts/commit-email.pl.in
> both introduced bugs:
>
> ------------------------------------------------------------------------
> r13107 | maxb | 2005-02-22 04:24:08 -0500 (Tue, 22 Feb 2005) | 7 lines
>
> commit-email.pl: Temporary directory handling changes.
>
> * tools/hook-scripts/commit-email.pl.in:
> Add a comment marking the end of the configuration section.
> If $TEMP is a directory, change to that, not /tmp.
> Comment that this tempdir code isn't required for svnlook >= 1.1.0 anyway.
> ------------------------------------------------------------------------
>
> This generates a Perl warning if $ENV{'TEMP'} isn't defined. A
> (defined $ENV{'TEMP'}) can be added to the conditional, or as he says
> the tempdir stuff could just be removed.
>
> ------------------------------------------------------------------------
> r12602 | fitz | 2005-01-05 13:23:09 -0500 (Wed, 05 Jan 2005) | 6 lines
>
> Set envelope sender.
>
> Patch by: Ben Laurie <ben@algroup.co.uk>
>
> * commit-email.pl: Set envelope sender when sending mail.
> ------------------------------------------------------------------------
>
> The envelope sender should be quoted, otherwise the script breaks on
> From addresses with spaces (such as any full address "Jim <jim@jtan.com>").
>
> Patch for both attached.
>
> -jim

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 18 23:51:44 2005

This is an archived mail posted to the Subversion Dev mailing list.