Re: Crash with 'svn st -u' and Version 1.3 (1.3.x branch)

Daniel Rall <dlr@finemaltcoding.com> writes:

> To fix this problem, checking for a NULL value for "svn:author" is really
> all that's needed, but perhaps the following patch would be better (given
> that it's more defensive against other unexpected NULL values)?

No comments on the patch, but I have difficulty understanding the doc
string for svn_wc_status2_t:

   * When the working copy item is out of date compared to the
   * repository, the following fields represent the state of the
   * youngest revision of the item in the repository. If not out of
   * date, the fields are set as described below.

That appears to state that the fields are valid when the wc is out of
date, but then this:

  /** Set to the user name of the youngest commit, or @c NULL if out
   * of date.
   * @since New in 1.3
   */
  const char *ood_last_cmt_author;

states that the value is NULL when out of date.

Is this field NULL when the wc is out of date, or NULL when the wc is
*not* out of date?

Is the caller expected to check for NULL to determine whether the
field is out of date?

Does your patch change the behaviour, i.e. it's now NULL for some
other reason?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org