Re: svn commit: r16735 - in trunk/subversion: libsvn_subr libsvn_wc

Hi,

In <200510151724.j9FHO4J08094@morbius.ch.collab.net>

> Author: djames
> New Revision: 16735

> --- trunk/subversion/libsvn_subr/constructors.c (original)
> +++ trunk/subversion/libsvn_subr/constructors.c Sat Oct 15 12:24:04 2005

> +svn_client_commit_item2_t *
> +svn_client_commit_item2_dup (const svn_client_commit_item2_t *item,
> + apr_pool_t *pool)
> +{
> + svn_client_commit_item2_t *new_item = apr_palloc (pool, sizeof (*new_item));
> +
> + *new_item = *item;
> +
> + if (new_item->path)

     if (new_item->kind && new_item->path)

We need to check new_item->kind value is svn_node_none or
not. Or we initialize item->path as NULL if item->path is
not available.

> + new_item->path = apr_pstrdup (pool, new_item->path);
> +
> + if (new_item->url)
> + new_item->url = apr_pstrdup (pool, new_item->url);

     if (new_item->copyfrom_url)
       new_item->copyfrom_url = apr_pstrdup (pool, new_item->copyfrom_url);

We need to copy new_item->copyfrom_url.

> +
> + if (new_item->wcprop_changes)

I think we need to check new_item->wcprop_changes is
available or not. But I don't know the way...

Can we initialize item->wcprop_changes as NULL?

> + new_item->wcprop_changes = svn_prop_array_dup (new_item->wcprop_changes,
> + pool);
> +
> + return new_item;
> +}

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org