Re: svn commit: r16694 - in trunk/subversion: libsvn_client libsvn_ra libsvn_ra_dav libsvn_ra_local libsvn_ra_svn svnserve

On Thu, 2005-10-13 at 07:10 -0500, lundblad@tigris.org wrote:
> +static svn_error_t *open_session(ra_svn_session_baton_t **sess_p,
> + const char *url,
> + apr_hash_t *config,
> + svn_auth_baton_t *auth_baton,
> + apr_pool_t *pool)

> + sess->config = config;

You're storing the config hash which was provided by the caller of
svn_ra_open() and using it later. svn_ra_open() does not require that
the config hash's lifetime last as long as the session, or that it not
be changed after the svn_ra_open() call.

In my vision of svn_ra_reparent(), the caller was made responsible for
dealing with the case where the server does not support reparent
operations. I don't much like the idea of svn_ra operations
"transparently" opening new connections when they have to, since opening
a connection is often a user-visible operation.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 13 19:41:29 2005