[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16652 - trunk/subversion/include

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-10-11 21:40:32 CEST

> djames@tigris.org writes:
>
>>--- trunk/subversion/include/svn_opt.h (original)
>>+++ trunk/subversion/include/svn_opt.h Tue Oct 11 10:01:32 2005
>>@@ -202,10 +202,12 @@
>> };
>>
>> /**
>>- * A revision value, which can be stored in one of @c svn_opt_revision_kind
>>- * ways.
>>+ * A revision value, which can be specified as a number or a date.
>>+ * @note This union should only be used in a @c svn_opt_revision_t struct.

Why? When I first saw this patch I thought "Do we really want to make this
symbol public? Probably not - but there's no harm in it. OK, let it be
public." Now your comment is effectively saying "This is private" - which is
fine except that I expect private things to have private names.

If this has a public-style name because SWIG requires it, the comment should
say so, otherwise a future programmer will likely change it to a private name.

On the other hand, if we use the union and need to make it public, why not let
other clients use it too?

- Julian

>>+ * @since New in 1.3.
>> */
>>-typedef union svn_opt_revision_value {
>>+typedef union svn_opt_revision_value
>>+{
>> svn_revnum_t number;
>> apr_time_t date;
>> } svn_opt_revision_value;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 11 21:41:23 2005

This is an archived mail posted to the Subversion Dev mailing list.