Re: [PATCH] Issue #2287 - Make svn_client_log() take a peg revision

kfogel@collab.net wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>
>>Sorry for the long delay in replying. I looked at this a couple of
>>times but still couldn't understand what is going on here.
>>
>>Could anyone else take a look at this?

Thanks for taking a look, Karl.

> I think it's a correctness problem.
[...]
> Subversion first goes to r100 [...] and *then* looks around for 'folder1',
> which of course doesn't exist -- and even if it did exist, it might be
> the wrong object.

Yes, absolutely, that's why this enhancement is needed. As usual, I didn't use
enough words to explain myself.

> The discussion below about whether to pass the start revision versus
> the end revision of the range to svn_client__ra_session_from_path() is
> a red herring, I think.

Ah, a red herring it may be, but that's the part I meant I "couldn't
understand". That's where I got hung up on trying to review the patch. In my
previous email or two in the thread I queried this, trying to discover why this
particular part of the patch does what it does, and I couldn't understand
Ramaswamy's answers.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 11 02:54:03 2005