Currently, psvn.el assigns global meanings to symbols that match the
(svn-add-face, svn-alist, svn-alist-convert-widget, svn-browse-url,
svn-browse-url-function, svn-global-keymap, svn-global-trac-map,
(svn-process-cmd, svn-process-filter, svn-process-kill,
psvn (defgroup, provide)
(match-string-no-properties, point-at-bol, point-at-eol, puthash,
According to (elisp)Coding Conventions ("If a package needs to define"
...), at least the compatibility definitions should be renamed to begin
with a "package prefix". Am I correct in assuming that:
"svn-" is the package prefix used in psvn.el. There are also longer
prefixes which clarify the code and help symbol completion, but they
are not intended to prevent name clashes with other packages. All
interactive commands meant to be used only in a specific mode should
have names beginning with the name of that mode: for example,
"svn-status-add-file" in "svn-status-mode". "psvn" should be used
only in names of files, customization groups, and features. If SVK
support is ever added, it should use "svn-svk-" when no existing
prefix is applicable.
If so, this should be added as a comment in psvn.el, I think.
trunk/tools/dev/svn-dev.el also uses names beginning with "svn-". I
haven't checked whether there are any conflicts between that and psvn.el.
Received on Mon Oct 10 20:24:26 2005
- application/pgp-signature attachment: stored